Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does this work deal with the workload balance when scheduing? #17

Closed
andakai opened this issue Mar 25, 2024 · 5 comments
Closed

Does this work deal with the workload balance when scheduing? #17

andakai opened this issue Mar 25, 2024 · 5 comments
Labels
question Further information is requested

Comments

@andakai
Copy link

andakai commented Mar 25, 2024

No description provided.

@AjayP13
Copy link
Collaborator

AjayP13 commented Mar 25, 2024

I assume you're talking about this:
vllm-project/vllm#1237 (comment)

But yes, it does balance the work between multiple instances of the vLLM model.

@AjayP13 AjayP13 closed this as completed Mar 25, 2024
@andakai
Copy link
Author

andakai commented Mar 25, 2024

Yes, I am trying to do dataparallel using vLLM based on your project.
I have read the guide, but still feel confused about how to do this. I wonder if there is any specific doc or example?

@AjayP13
Copy link
Collaborator

AjayP13 commented Mar 25, 2024

You can see this test case right here (test_parallel_llm) for some example code:

def test_parallel_llm(self, create_datadreamer, mocker):

That test case will run a two copies of an LLM (one per GPU on a 2-GPU machine) using Hugging Face Transformers.

If you want to use VLLM instead of HFTransformers instead, it's as simple as:

from datadreamer.llms import VLLM, ParallelLLM
llm_1 = VLLM("gpt2", device=0)
llm_2 = VLLM("gpt2", device=1)
parallel_llm = ParallelLLM(llm_1, llm_2)

@andakai
Copy link
Author

andakai commented Mar 25, 2024

wow this is so easy to use. It helps me a lot. Thanks for your fantastic work.

@AjayP13
Copy link
Collaborator

AjayP13 commented Mar 25, 2024

No problem, let me know if you need any other help!

@AjayP13 AjayP13 added the question Further information is requested label Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants