Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new PR categories for Docs, Spark QA, and EC2 #10

Closed
nchammas opened this issue Aug 30, 2014 · 5 comments
Closed

Add new PR categories for Docs, Spark QA, and EC2 #10

nchammas opened this issue Aug 30, 2014 · 5 comments

Comments

@nchammas
Copy link
Contributor Author

Actually, it just occurred to me that perhaps the PR categories should be derived from the list of components in the Spark JIRA project.

@JoshRosen
Copy link
Contributor

The backend is now collecting the information needed to automatically categorize PRs based on the paths of the files that they change.

One tricky problem: how do we display PRs that touch multiple components? For example, pull requests that add Python bindings to SparkSQL or MLlib might touch files inside of /python.

@nchammas
Copy link
Contributor Author

Sounds good. I'd imagine displaying the PR under each category it applies to is a good way to go.

In the MLlib + Python example, an MLlib reviewer might focus on making sure the Python API for a given method matches the same APIs for other languages, while a Python reviewer might just focus on Python style and best practices.

@pwendell
Copy link

I agree with the proposal by @nchammas - let's show it under multiple categories for now. I do wonder how many will overlap with spark core though... we'll have to see.

@JoshRosen
Copy link
Contributor

Alright, pushed a version of this live. It should be really easy to modify the regexes used to specify components, so PRs to refine them are welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants