-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Pandas >2.0 #726
Comments
Our upstream dependencies at dbt Labs have communicated to me that they are going to be pinning to numpy < 2, so even if I remove the pandas pin, we can't expect numpy 2 to work. We need to verify that a newer Pandas works as well, as the reason we started pinning is that newer Pandas started breaking dbt-databricks. Keeping the ticket open to try upgrading Pandas again at some point. |
@benc-db It's all fine. I fixed the version for myself and made sure it is known in the community. ;) tanks. |
For anyone else who sees this issue, newer versions of pandas also drop support for python 3.8, which we are not prepared to drop support for yet. |
@benc-db Can you take another look at this given the latest releases to pandas/numpy. The current state is blocking any upgrades to python 3.13. Not immediately problematic but would be good to know there is a solution that will eventually unblock this 👍 |
Thanks for bringing this back to my attention. We have dropped support for 3.8, so I can look into this again. |
@benc-db do you have a rough idea of when (or what version) we will be able to upgrade to python 3.13? I saw there was a PR up for this already 👍 |
We likely need to wait to support python 3.13 until dbt-adapters does. Dropping the pandas pin can happen as soon as 1.9.1, probably releasing early January. |
1.9.0 still requires the numpy version between 1.23.4 and 1.26.4. I am curious to see if 1.9.1 changes this. |
Update: I have updated to the latest version 1.9.1 and now it works without any workaround. I ran into some new issues/warnings, but I will create new tickets for that. |
Describe the bug
Since Numpy released its latest version 2.0, it is not compatible with an older version of Pandas. However, dbt-databricks in version 1.8.3 only supports pandas up to version 2.0.
Workaround: fix numpy version to 1.26.4 (latest before 2.0).
Steps To Reproduce
requirements.txt
with only few entries:dbt deps
dbt compile
Expected behavior
Successfull dbt run.
Screenshots and log output
The outcome of the commans:
DBT now has installed the packages.
But it fails in any other execution (in this case, it is
dbt compile
):Quote from the logs:
System information
The output of
dbt --version
:The operating system you're using:
The output of
python --version
:Additional context
The text was updated successfully, but these errors were encountered: