Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is the urllib3<2 pin necessary? #644

Closed
jtilly opened this issue May 23, 2023 · 4 comments
Closed

Is the urllib3<2 pin necessary? #644

jtilly opened this issue May 23, 2023 · 4 comments
Assignees

Comments

@jtilly
Copy link

jtilly commented May 23, 2023

Currently, urllib3 is pinned:

'urllib3>=1.26.7,<2.0.0'

This happened in #637. Is this pin (still) necessary?

The PR description makes it sound like we needed this pin for requests. But requests should be fine with urllib3<3, see here.

This caused some hiccups on the conda packaging side (where the pin was missing), see conda-forge/databricks-cli-feedstock#23.

@shreyas-goenka
Copy link
Contributor

@jtilly You are right, the upper bound can be increased to 3 here. I have created an issue for tracking this in our backlog. Please let us know if this is blocking and we can prioritize cutting a PR for this.

#645

@mrmasterplan
Copy link

+1 this breaks my pipeline. I would appreciate a fix.

@jtilly
Copy link
Author

jtilly commented May 25, 2023

Please let us know if this is blocking and we can prioritize cutting a PR for this.

Thank you! Not blocking for me, but a PR would be appreciated 😉

@mgyucht
Copy link
Contributor

mgyucht commented Oct 4, 2023

This is addressed in #664.

@mgyucht mgyucht closed this as completed Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants