-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Weird method naming for pushing data #2
Comments
I find it weird too.
Simply by adding a line of code in the beggining of the original method ( |
Deprecate .insertAll(), providing backwards legacy compatibillity .insertAll()
;) |
We used I would also avoid detecting "type" with |
Original code of .push() VS insertAll():
In the firt one, is wrapping I can understand you want to keep the Databox look and feel, unified accross libraries (even if some implementations are weird), but but considering, i (as many users) will only interact with this library, i prefer to have a single method for processing all my queries. Anyway, it was just a personal suggetion, for people, like @JanHalozan who is missing a simplified and more clear way of pushing data. |
I find it weird why do there have to be two methods for pushing data. There is
push
for pushing a single KPI andinsertAll
for pushing an array. I think it would be better if there was onlypush
. And of this is not possible perhaps unify the naming to something likeinsert
andinsertAll
.The text was updated successfully, but these errors were encountered: