Skip to content

refactor: use cursor instead of BufferReader for input format #8486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
youngsofun opened this issue Oct 27, 2022 · 0 comments · Fixed by #8716
Closed

refactor: use cursor instead of BufferReader for input format #8486

youngsofun opened this issue Oct 27, 2022 · 0 comments · Fixed by #8716
Assignees

Comments

@youngsofun
Copy link
Member

youngsofun commented Oct 27, 2022

  1. currently, also usage is MemoryReader (with all data already readn).
  2. in the future, async is slow, the current BufferReader interfaces are all sync; while we are not likely to read the underlying Reader syncly
  3. not assuming any underlying Reader save a lot of cost
    4. most of all, no need to alloc and copy for the buf
    1. not need loop and the call to fill_buffer.
    2. not need to return Result and than unwarp for most fn.
    3. checkpointing is much easier, no need to maintain a copy of data.

also prepare for new expression

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant