Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update sqlparser-rs to latest to support Unsigned* #4877

Closed
BohuTANG opened this issue Apr 15, 2022 · 1 comment · Fixed by #4880
Closed

Update sqlparser-rs to latest to support Unsigned* #4877

BohuTANG opened this issue Apr 15, 2022 · 1 comment · Fixed by #4880
Assignees
@TCeason
Labels
dependencies Pull requests that update a dependency file
Milestone
v0.8

Comments

@BohuTANG
Copy link
Member

Summary

sqlparser-rs is support unsigned numeric type:
https://github.com/sqlparser-rs/sqlparser-rs/blob/994b86a45c632c092993371e53cfb23a823dfaa2/src/ast/data_type.rs#L49-L61

We should update it and then support the unsigned syntax:

create table t1(int unsigned);
@BohuTANG BohuTANG added the dependencies Pull requests that update a dependency file label Apr 15, 2022
@BohuTANG BohuTANG assigned sundy-li and TCeason and unassigned sundy-li Apr 15, 2022
@BohuTANG BohuTANG mentioned this issue Apr 15, 2022
Closed
55 tasks
@BohuTANG
Copy link
Member Author

It's hard to merge with upstream, better to back port.

@BohuTANG BohuTANG mentioned this issue Apr 16, 2022
Merged
@Xuanwo Xuanwo added this to the v0.8 milestone May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TCeason TCeason

Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
v0.8
Development

Successfully merging a pull request may close this issue.

chore(data type): make data type syntax standardization BohuTANG/databend
4 participants
@BohuTANG @sundy-li @Xuanwo @TCeason