Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

two-level hashmap optimization #4602

Closed
BohuTANG opened this issue Mar 27, 2022 · 3 comments · Fixed by #5075
Closed

two-level hashmap optimization #4602

BohuTANG opened this issue Mar 27, 2022 · 3 comments · Fixed by #5075
Assignees
@fkuner
Labels
A-query Area: databend query C-improvement Category: improvement community-take v0.8
Milestone
v0.8

Comments

@BohuTANG
Copy link
Member

Yes, as the number of stored keys increases we did not have the two-level hashmap optimization like ClickHouse.
It can be enhanced in the future.

Originally posted by @sundy-li in #4600 (comment)
@BohuTANG BohuTANG added C-improvement Category: improvement A-query Area: databend query labels Mar 27, 2022
@BohuTANG BohuTANG mentioned this issue Mar 27, 2022
Closed
55 tasks
@BohuTANG BohuTANG added the v0.8 label Apr 1, 2022
@GrapeBaBa
Copy link
Contributor

Except ClickHouse any other database implement this optimization?

@sundy-li
Copy link
Member

Except ClickHouse any other database implement this optimization?

I don't know. This looks very common in hashmap implementation.

@fkuner
Copy link
Contributor

fkuner commented Apr 20, 2022

/assignme

@fkuner fkuner mentioned this issue Apr 28, 2022
Merged
@Xuanwo Xuanwo added this to the v0.8 milestone May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fkuner fkuner

Labels
A-query Area: databend query C-improvement Category: improvement community-take v0.8
Projects
None yet
Milestone
v0.8
Development

Successfully merging a pull request may close this issue.

feat(group_by): support two-level hashmap fkuner/databend
6 participants
@BohuTANG @sundy-li @GrapeBaBa @Xuanwo @fkuner @databend-bot