Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get_notebook_name() fails in JupyterHub #44

Closed
jfischer opened this issue Nov 14, 2019 · 2 comments
Closed

get_notebook_name() fails in JupyterHub #44

jfischer opened this issue Nov 14, 2019 · 2 comments

Comments

@jfischer
Copy link
Collaborator

The protocol with IPython seems to be different. It is actually throwing an exception which causes the lineage code to fail.
@jfischer
Copy link
Collaborator Author

This is related to jupyter/notebook#1000. It is still an open issue in general. Might have to force the user to include a name when running on JupyterHub.

@jfischer jfischer changed the title get_notebook_name() fails in JupyterLab get_notebook_name() fails in JupyterHub Nov 16, 2019
@jfischer
Copy link
Collaborator Author

jfischer commented Dec 8, 2019

This is largely addressed by using the Jupyter magic to find out the notebook name. If the user doesn't load the Jupyter magic or specify the notebook name explicitly, they get an error.

@jfischer jfischer closed this as completed Dec 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jfischer