From 55bb8b1a0201217639d2fb928e05aef4ed5346c1 Mon Sep 17 00:00:00 2001 From: Matthew Rocklin Date: Tue, 29 Mar 2022 16:54:35 -0500 Subject: [PATCH 1/2] Add tiny test for ToPickle --- distributed/protocol/tests/test_protocol.py | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/distributed/protocol/tests/test_protocol.py b/distributed/protocol/tests/test_protocol.py index 5c6b67f757..6402fe57c9 100644 --- a/distributed/protocol/tests/test_protocol.py +++ b/distributed/protocol/tests/test_protocol.py @@ -6,6 +6,7 @@ from distributed.protocol.serialize import ( Serialize, Serialized, + ToPickle, dask_deserialize, dask_serialize, deserialize, @@ -253,3 +254,14 @@ def _(header, frames): header, frames = serialize(MyObj(), serializers=serializers) o = deserialize(header, frames) assert isinstance(o, MyObj) + + +def test_ToPickle(): + class Foo: + def __init__(self, data): + self.data = data + + msg = {"x": ToPickle(Foo(123))} + frames = dumps(msg) + out = loads(frames) + assert out["x"].data == 123 From 2ac24e575c4546256b83f15a615f2c06c7c7ff96 Mon Sep 17 00:00:00 2001 From: Matthew Rocklin Date: Wed, 30 Mar 2022 08:45:06 -0500 Subject: [PATCH 2/2] move test --- distributed/protocol/tests/test_protocol.py | 12 ------------ distributed/protocol/tests/test_to_pickle.py | 12 ++++++++++++ 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/distributed/protocol/tests/test_protocol.py b/distributed/protocol/tests/test_protocol.py index 6402fe57c9..5c6b67f757 100644 --- a/distributed/protocol/tests/test_protocol.py +++ b/distributed/protocol/tests/test_protocol.py @@ -6,7 +6,6 @@ from distributed.protocol.serialize import ( Serialize, Serialized, - ToPickle, dask_deserialize, dask_serialize, deserialize, @@ -254,14 +253,3 @@ def _(header, frames): header, frames = serialize(MyObj(), serializers=serializers) o = deserialize(header, frames) assert isinstance(o, MyObj) - - -def test_ToPickle(): - class Foo: - def __init__(self, data): - self.data = data - - msg = {"x": ToPickle(Foo(123))} - frames = dumps(msg) - out = loads(frames) - assert out["x"].data == 123 diff --git a/distributed/protocol/tests/test_to_pickle.py b/distributed/protocol/tests/test_to_pickle.py index 7db7a5d973..d3099c9a73 100644 --- a/distributed/protocol/tests/test_to_pickle.py +++ b/distributed/protocol/tests/test_to_pickle.py @@ -4,10 +4,22 @@ from dask.highlevelgraph import HighLevelGraph, MaterializedLayer from distributed.client import Client +from distributed.protocol import dumps, loads from distributed.protocol.serialize import ToPickle from distributed.utils_test import gen_cluster +def test_ToPickle(): + class Foo: + def __init__(self, data): + self.data = data + + msg = {"x": ToPickle(Foo(123))} + frames = dumps(msg) + out = loads(frames) + assert out["x"].data == 123 + + class NonMsgPackSerializableLayer(MaterializedLayer): """Layer that uses non-msgpack-serializable data"""