Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New tests for gather_dep are flaky #5406

Closed
crusaderky opened this issue Oct 11, 2021 · 0 comments · Fixed by #5426
Closed

New tests for gather_dep are flaky #5406

crusaderky opened this issue Oct 11, 2021 · 0 comments · Fixed by #5426
Labels
flaky test Intermittent failures on CI.

Comments

@crusaderky
Copy link
Collaborator

The two tests introduced by #5160 are flaky:

FAILED distributed/tests/test_worker.py::test_gather_dep_do_not_handle_response_of_not_requested_tasks
FAILED distributed/tests/test_worker.py::test_gather_dep_no_longer_in_flight_tasks

They frequently fail with error message

E TypeError: tuple indices must be integers or slices, not str

See e.g.

CC @fjetter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flaky test Intermittent failures on CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Deadlock - Ensure resumed flight tasks are still fetched fjetter/distributed
2 participants
@crusaderky @GenevieveBuckley