Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Worker plugin is not notified when worker releases task #3815

Closed
nre opened this issue May 19, 2020 · 1 comment · Fixed by #3817
Closed

Worker plugin is not notified when worker releases task #3815

nre opened this issue May 19, 2020 · 1 comment · Fixed by #3817

Comments

@nre
Copy link
Contributor

nre commented May 19, 2020

The worker plugin is notified when a task changes state but not when the task is released.

@mrocklin asked whether release_key should be added to the worker plugin API.

Alternatively, release_key could notify the worker plugin that the task has transitioned to "forgotten", which is consistent with the behaviour of the scheduler plugin.

I am keen to implement either solution.

@jacobtomlinson
Copy link
Member

I think that given the worker is still working on the task, despite it being released, means that moving to forgotten doesn't make sense.

A PR to add release_key to the worker plugin would be a nice addition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants