Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

fix: strange error on deletion of specific data set #90

Merged
merged 8 commits into from
Mar 17, 2022

Conversation

jawid-h
Copy link
Collaborator

@jawid-h jawid-h commented Mar 16, 2022

Issue being fixed or feature implemented

Deleting of some specific data created in JS Drive tests lead to no deleting that data. Fixed by dashpay/grovedb#81

What was done?

  • Recreated data set with data
  • updated grovedb

How Has This Been Tested?

With tests

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@QuantumExplorer QuantumExplorer marked this pull request as ready for review March 17, 2022 10:47
@shumkov shumkov changed the title chore(test): unknown data bug fix: strange error on deletion of specific data set Mar 17, 2022
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! 👍

@QuantumExplorer QuantumExplorer merged commit 2b65a18 into v0.23-dev Mar 17, 2022
@QuantumExplorer QuantumExplorer deleted the unknown-data-bug branch March 17, 2022 11:02
@shumkov
Copy link
Member

shumkov commented Mar 17, 2022

Fixed #83

shumkov pushed a commit to dashpay/platform that referenced this pull request Nov 23, 2022
…orm#90)

* chore(test): unknown data bug

* chore: incomplete

* chore: wip

* added transaction

* cleanup

* updated to master

Co-authored-by: Quantum Explorer <quantum@dash.org>
shumkov pushed a commit to dashpay/platform that referenced this pull request Nov 23, 2022
…orm#90)

* chore(test): unknown data bug

* chore: incomplete

* chore: wip

* added transaction

* cleanup

* updated to master

Co-authored-by: Quantum Explorer <quantum@dash.org>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants