Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

feat: insert with parents for Document #189

Merged
merged 6 commits into from
Nov 22, 2022

Conversation

qrayven
Copy link
Contributor

@qrayven qrayven commented Nov 21, 2022

Issue being fixed or feature implemented

js-dpp uses lodash lib to set values in Document. While setting the value, intermediate structures provided in path that don't exist are automatiaclly created.
This funcionality is being implemented for serde_json::Value

What was done?

How Has This Been Tested?

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

antouhou
antouhou previously approved these changes Nov 22, 2022
Copy link
Collaborator

@antouhou antouhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

Copy link
Collaborator

@antouhou antouhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@qrayven qrayven merged commit 34073ab into v0.24-dev Nov 22, 2022
@qrayven qrayven deleted the feat/document/insert-with-parents branch November 22, 2022 15:42
shumkov pushed a commit to dashpay/platform that referenced this pull request Nov 23, 2022
* feat: insert with parents for Document

* setter and getter for data

* adress the comments

* fix test in drive
shumkov pushed a commit to dashpay/platform that referenced this pull request Nov 23, 2022
* feat: insert with parents for Document

* setter and getter for data

* adress the comments

* fix test in drive
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants