Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(drive): non-deterministic run of mn identities sync #910

Merged
merged 1 commit into from
Apr 14, 2023

Conversation

shumkov
Copy link
Member

@shumkov shumkov commented Apr 13, 2023

Issue being fixed or feature implemented

If some nodes were restarted or missed some rounds during consensus polka, masternode identities synchronization can be called in non-deterministic manner due to in-memory state.

What was done?

  • Remove in-memory state for synchronize masternode identities logic

How Has This Been Tested?

None

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shumkov shumkov requested a review from antouhou as a code owner April 13, 2023 03:01
@shumkov shumkov added this to the v0.24.0 milestone Apr 13, 2023
@shumkov shumkov merged commit 63741c7 into v0.24-dev Apr 14, 2023
@shumkov shumkov deleted the fix/drive/non-deterministc-identity-sync branch April 14, 2023 05:36
@markin-io markin-io mentioned this pull request Apr 26, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants