Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dashmate): api binds to all interfaces #893

Merged
merged 28 commits into from
Apr 7, 2023
Merged

fix(dashmate): api binds to all interfaces #893

merged 28 commits into from
Apr 7, 2023

Conversation

pshenmic
Copy link
Collaborator

@pshenmic pshenmic commented Apr 7, 2023

Issue being fixed or feature implemented

Bind dashmate to localhost for security reason.

What was done?

  • bind dashmate rpc api to 127.0.0.1
  • add curl to dashmate docker image (used in smoke tests)

How Has This Been Tested?

Locally

Breaking Changes

No

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

pshenmic and others added 28 commits April 6, 2023 08:51
@pshenmic
feat(dashmate): upgrade @oclif/core to v2
e013b66
@pshenmic
feat(dashmate): implement json rpc api
bc408f1
@pshenmic
fix(dashmate): add missing await
2a7abed
@pshenmic
feat(dashmate): add configuration for json rpc api
d09c87f
@pshenmic
feat(dashmate): remove redundant config pointer
bdfa47c
@pshenmic
fix(dashmate): remove port hardcode
07ece0a
@pshenmic
chore(dashmate): fix lint
c61c63e
@pshenmic
chore(dashmate): fix lint
3e3a84f
@pshenmic
chore(dashmate): fix lint
1d31b59
@shumkov
refactor: http server
4d393cc
@pshenmic
chore(dashmate): fix leftovers
6fc89ee
@pshenmic
fix(dashmate): fix container
b1864e5
@pshenmic
fix(dashmate): cleanup
cb5bfcb
@pshenmic
fix(dashmate): env
c561b95
@pshenmic
fix(dashmate): cleanup
6997ab9
@pshenmic
fix(dashmate): cleanup
ffa0153
@pshenmic
chore(dashmate): downgrade to latest stable v1
b825c61
@pshenmic
fix(dashmate): correct env
50a7ff0
@shumkov
fix: api is not required in config schema
36bc2bd
@pshenmic
Merge remote-tracking branch 'origin/v0.24-dev' into feat/dashmate-js…
ca7e338 
…on-rpc
@pshenmic
fix(dashmate): add rs-drive-verify-c-binding to Dockerfile
14241d1
@pshenmic
Merge remote-tracking branch 'origin/feat/dashmate-json-rpc' into fea…
94484eb 
…t/dashmate-json-rpc
@pshenmic
fix(js-drive): add rs-drive-verify-c-binding to Dockerfile
59d4766
@pshenmic
chore(dashmate): revert rs drive package
e4dd36d
@pshenmic
Merge remote-tracking branch 'origin/v0.24-dev' into feat/dashmate-js…
fb8bd02 
…on-rpc
@pshenmic
fix(dashmate): stick dashmate json rpc to localhost
cf3ce2b
@pshenmic
chore(dashmate): include curl in the dashmate docker image
039c89e
@pshenmic
chore(dashmate): include curl in the dashmate docker image
f8bc518
@shumkov shumkov changed the title feat(dashmate): bind dashmate json rpc to localhost fix(dashmate): dashmate api binds to all interfaces Apr 7, 2023
@shumkov shumkov changed the title fix(dashmate): dashmate api binds to all interfaces fix(dashmate): api binds to all interfaces Apr 7, 2023
shumkov
shumkov approved these changes Apr 7, 2023
View reviewed changes
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@shumkov shumkov merged commit c3e5a71 into v0.24-dev Apr 7, 2023
@shumkov shumkov deleted the feat/dashmate-json-rpc branch April 7, 2023 17:07
@thephez thephez added this to the v0.24.0 milestone Apr 24, 2023
markin-io pushed a commit that referenced this pull request Apr 26, 2023
@pshenmic @shumkov @markin-io
fix(dashmate): api binds to all interfaces (#893)
adab032 
Co-authored-by: Ivan Shumkov <ivan@shumkov.ru>
@markin-io markin-io mentioned this pull request Apr 26, 2023
Merged
5 tasks
markin-io pushed a commit that referenced this pull request Apr 26, 2023
@pshenmic @shumkov @markin-io
fix(dashmate): api binds to all interfaces (#893)
4843a8b 
Co-authored-by: Ivan Shumkov <ivan@shumkov.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shumkov shumkov shumkov approved these changes

@antouhou antouhou Awaiting requested review from antouhou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.24.0
Development

Successfully merging this pull request may close these issues.
3 participants
@pshenmic @shumkov @thephez