Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: identifier deserialization doesn't work for bincode #885

Merged
merged 1 commit into from
Apr 4, 2023
Merged

fix: identifier deserialization doesn't work for bincode #885

merged 1 commit into from
Apr 4, 2023

Conversation

shumkov
Copy link
Member

@shumkov shumkov commented Apr 4, 2023 •
edited
Loading

Issue being fixed or feature implemented

Identifier deserialization doesn't work for bincode

What was done?

  • switched to byte visitor (thanks to @QuantumExplorer )
  • removed unused Identifier::from_json_object
  • added constructors to some of wasm consensus errors for testing

How Has This Been Tested?

With tests

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shumkov shumkov added this to the v0.24.0 milestone Apr 4, 2023
@shumkov shumkov requested a review from antouhou as a code owner April 4, 2023 13:59
@shumkov shumkov merged commit f3a8a58 into v0.24-dev Apr 4, 2023
@shumkov shumkov deleted the fix/identifier-deserialization branch April 4, 2023 14:02
markin-io pushed a commit that referenced this pull request Apr 26, 2023
@shumkov @markin-io
fix: identifier deserialization doesn't work for bincode (#885)
97331d3
@markin-io markin-io mentioned this pull request Apr 26, 2023
Merged
5 tasks
markin-io pushed a commit that referenced this pull request Apr 26, 2023
@shumkov @markin-io
fix: identifier deserialization doesn't work for bincode (#885)
151eae7
@coderabbitai coderabbitai bot mentioned this pull request Dec 16, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuantumExplorer QuantumExplorer QuantumExplorer approved these changes

@antouhou antouhou Awaiting requested review from antouhou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.24.0
Development

Successfully merging this pull request may close these issues.
2 participants
@shumkov @QuantumExplorer