Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(drive): handle quorum rotation failure #858

Merged
merged 5 commits into from
Apr 17, 2023

Conversation

shuplenkov
Copy link
Collaborator

@shuplenkov shuplenkov commented Mar 24, 2023

Issue being fixed or feature implemented

To handle quorum rotation error, we need to call “quorum info“ and verify previouslyFailedConsecutiveDKGs == 0 before instant lock signature verification.

What was done?

Modified Drive's instant lock signature verification method to make quorum info calls

How Has This Been Tested?

With tests

Breaking Changes

No

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shuplenkov shuplenkov added this to the v0.24.0 milestone Mar 24, 2023
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@shuplenkov shuplenkov merged commit ee061b6 into v0.24-dev Apr 17, 2023
@shuplenkov shuplenkov deleted the quorum_rotation_failure branch April 17, 2023 13:20
@markin-io markin-io mentioned this pull request Apr 26, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants