fix(sdk)!: dapi-grpc generated files overwritten on conflicting features #1854
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
When dapi-grpc is built with another set of enabled features, it overwrites previously generated files.
It means that if two crates in a project use dapi-grpc, it might result in non-deterministic build failures,
depending on build order.
What was done?
Each combination of features generates source files in a separate subdirectory.
The following features are considered:
client
,server
.It means we can have up to 3 different directories (
client
,server
,client_server
)serde
feature is controlled usingcfg_attr
macro.How Has This Been Tested?
GHA, trying to build it locally
Breaking Changes
default
feature set ofdapi-grpc
crate now includes onlyclient
,core
andplatform
.Checklist:
For repository code-owners and collaborators only