Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sdk)!: dapi-grpc generated files overwritten on conflicting features #1854

Merged
merged 7 commits into from
May 23, 2024

Conversation

lklimek
Copy link
Contributor

@lklimek lklimek commented May 22, 2024

Issue being fixed or feature implemented

When dapi-grpc is built with another set of enabled features, it overwrites previously generated files.
It means that if two crates in a project use dapi-grpc, it might result in non-deterministic build failures,
depending on build order.

What was done?

Each combination of features generates source files in a separate subdirectory.
The following features are considered: client, server.
It means we can have up to 3 different directories (client, server, client_server)

serde feature is controlled using cfg_attr macro.

How Has This Been Tested?

GHA, trying to build it locally

Breaking Changes

default feature set of dapi-grpc crate now includes only client, core and platform.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@lklimek lklimek changed the title fix(dapi-grpc)!: change of features overwrite generated files fix(sdk)!: dapi-grpc generated files overwritten when features change May 22, 2024
@lklimek lklimek changed the title fix(sdk)!: dapi-grpc generated files overwritten when features change fix(sdk)!: dapi-grpc generated files overwritten on conflicting features May 22, 2024
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lklimek lklimek merged commit e81e699 into v1.0-dev May 23, 2024
57 checks passed
@lklimek lklimek deleted the fix/dapi-grpc-build-features-conflict branch May 23, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants