chore: fix test suite configuration script

[shumkov]

Issue being fixed or feature implemented

The test suite network configuration script doesn't work

What was done?

• Fixed fetching skip height

How Has This Been Tested?

Running locally

Breaking Changes

None

Checklist:

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have added or updated relevant unit/integration/functional/e2e tests
• I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
• I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

• I have assigned this pull request to a milestone

Summary by CodeRabbit

• Bug Fixes

  • Improved handling of INSIGHT_URL for devnet and testnet networks.
  • Enhanced dynamic calculation of SKIP_SYNC_BEFORE_HEIGHT to adapt to network state.

• Chores

  • Maintained existing error handling for dependencies and configuration checks.

[coderabbitai]

Walkthrough

The pull request modifies the configure_test_suite_network.sh script to improve network configuration handling. The key changes involve dynamically setting the INSIGHT_URL for different networks (devnet and testnet) and implementing a dynamic calculation of SKIP_SYNC_BEFORE_HEIGHT using a curl command and jq. The script retains its existing error handling mechanisms and maintains the overall control flow while enhancing its adaptability to different network configurations.

Changes

File	Change Summary
scripts/configure_test_suite_network.sh	- Removed hardcoded INSIGHT_URL for testnet - Added dynamic INSIGHT_URL assignment for devnet and testnet - Replaced static SKIP_SYNC_BEFORE_HEIGHT with dynamic height retrieval using curl and jq

Possibly related PRs

• fix(dashmate): failing doctor with drive metrics enabled #2348: Modifies URL construction for ABCI service metrics, potentially related to network configuration handling
• fix(dashmate): some group commands fail with mtime not found #2400: Addresses configuration options related to core.miner.mediantime, which may connect to configuration variable management

Suggested reviewers

• QuantumExplorer
• lklimek

Poem

🐰 A script that dances with networks so bright,
Fetching heights with curl's dynamic might!
No more hardcoded, now flexible and free,
Insight URLs singing in harmony!
Rabbit's code leaps with network delight! 🚀

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 2

🧹 Nitpick comments (1)

scripts/configure_test_suite_network.sh (1)

67-68: Consider caching mechanism for resilience

The script relies heavily on external API calls which could cause issues if the insight API is temporarily unavailable.

Consider implementing a caching mechanism or fallback values to improve reliability:

1. Cache the last known height in a local file
2. Use cached value if API call fails
3. Implement exponential backoff for retries

Would you like me to provide an implementation example?

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 37d5732 and 2a959f5.

📒 Files selected for processing (1)

• scripts/configure_test_suite_network.sh (1 hunks)