chore(dashmate): do not call mint on masternodes #2172
Conversation
Fixes #485 Update `dashmate wallet:mint` command to handle local configuration correctly and update documentation. * **Command Changes** - Update `runWithDependencies` function in `packages/dashmate/src/commands/wallet/mint.js` to check for `local_seed` configuration. - Add a check to ensure the specified config has `network == local`. - Add a check to ensure the node is not a masternode. * **Documentation Changes** - Update `packages/dashmate/README.md` to reflect the correct usage of the `mint` command. - Mention that the `--config=local_seed` option must be used for the local network. - Add a note about the spork parameters being set correctly in the configuration. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/dashpay/platform/issues/485?shareId=XXXX-XXXX-XXXX-XXXX).
WalkthroughThe changes introduce an additional error check in the Changes
Assessment against linked issues
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
packages/dashmate/src/commands/wallet/mint.js (1)
54-56: Approve the masternode check with a suggestion for error handling.The addition of this check aligns well with the PR objectives, preventing the minting of tDash on masternodes. This is a crucial safeguard that enhances the robustness of the minting process.
Consider consolidating error handling for a more unified approach:
if (network !== NETWORK_LOCAL) { - throw new Error('Only local network supports generation of dash'); + throw new MuteOneLineError('Only local network supports generation of dash'); } if (config.get('core.masternode.enable')) { - throw new Error(`A masternode doesn't support generation of dash`); + throw new MuteOneLineError(`A masternode doesn't support generation of dash`); }This change would ensure consistent error handling throughout the method, as
MuteOneLineErroris already used at the end of the method.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- packages/dashmate/src/commands/wallet/mint.js (1 hunks)
🔇 Additional comments (1)
packages/dashmate/src/commands/wallet/mint.js (1)
Line range hint
1-93: Verify the impact of the changes on the minting process.The addition of the masternode check enhances the robustness of the
MintCommandclass by preventing minting on masternodes. This aligns well with the PR objectives and addresses the issues raised.To ensure that this change doesn't introduce any unintended side effects, let's verify the usage of this command in other parts of the codebase:
This will help us identify any other parts of the codebase that might need to be updated in light of this new restriction.
✅ Verification successful
Verification Successful: No additional usages of
MintCommandorwallet:mintfound.The changes are confined to
mint.js, ensuring that the new masternode check does not affect other parts of the codebase.🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check for any other usages of the MintCommand that might be affected by this change. # Test: Search for references to MintCommand or wallet:mint rg --type js -i "(MintCommand|wallet:mint)"Length of output: 152
Fixes #485
Update
dashmate wallet:mintcommand to handle local configuration correctly and update documentation.Command Changes
runWithDependenciesfunction inpackages/dashmate/src/commands/wallet/mint.jsto check forlocal_seedconfiguration.network == local.Documentation Changes
packages/dashmate/README.mdto reflect the correct usage of themintcommand.--config=local_seedoption must be used for the local network.For more details, open the Copilot Workspace session.
Summary by CodeRabbit
New Features
Bug Fixes