fix(dpp): document factory wouldn't allow delete transitions for immutable document types #1956
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
DocumentFactoryV0
andSpecializedDocumentFactoryV0
were not allowing to create delete transitions if notdocument_type.documents_mutable()
, but it should have been checkingdocument_type.documents_can_be_deleted()
.What was done?
Changed the check and wrote a test. Also renamed the error message about not being able to delete immutable documents.
How Has This Been Tested?
Wrote a test for deleting immutable but deletable document types.
Breaking Changes
Checklist:
For repository code-owners and collaborators only