Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: minor issues detected by github actions #1928

Conversation

lklimek
Copy link
Contributor

@lklimek lklimek commented Jul 5, 2024

Issue being fixed or feature implemented

Github Actions detected a few minor issues in masternode voting code.

What was done?

Fixed issues.

Note: rs-dash-sdk tests fixed in #1927

How Has This Been Tested?

Run Github Actions: https://github.com/dashpay/platform/actions/runs/9807628771

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@lklimek lklimek changed the title fix: minor issues in tests fix: minor issues detected by github actions Jul 5, 2024
@lklimek lklimek marked this pull request as ready for review July 5, 2024 14:14
@QuantumExplorer QuantumExplorer merged commit 9ee1eae into feat/contestedDocumentResolutionWithMasternodeVoting Jul 5, 2024
86 of 90 checks passed
@QuantumExplorer QuantumExplorer deleted the fix/mn-voting-gha branch July 5, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants