-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(dashmate): core RPC platform services authentication #1883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # packages/dashmate/configs/getConfigFileMigrationsFactory.js
shumkov
added a commit
to dashpay/dash-network-deploy
that referenced
this pull request
Jun 23, 2024
5 tasks
# Conflicts: # .pnp.cjs # Cargo.lock # package.json # packages/bench-suite/package.json # packages/dapi-grpc/Cargo.toml # packages/dapi-grpc/package.json # packages/dapi/package.json # packages/dash-spv/package.json # packages/dashmate/configs/getConfigFileMigrationsFactory.js # packages/dashmate/package.json # packages/dashpay-contract/Cargo.toml # packages/dashpay-contract/package.json # packages/data-contracts/Cargo.toml # packages/dpns-contract/Cargo.toml # packages/dpns-contract/package.json # packages/feature-flags-contract/Cargo.toml # packages/feature-flags-contract/package.json # packages/js-dapi-client/package.json # packages/js-dash-sdk/package.json # packages/js-grpc-common/package.json # packages/masternode-reward-shares-contract/Cargo.toml # packages/masternode-reward-shares-contract/package.json # packages/platform-test-suite/package.json # packages/rs-dapi-client/Cargo.toml # packages/rs-dapi-grpc-macros/Cargo.toml # packages/rs-dpp/Cargo.toml # packages/rs-drive-abci/Cargo.toml # packages/rs-drive-proof-verifier/Cargo.toml # packages/rs-drive/Cargo.toml # packages/rs-platform-serialization-derive/Cargo.toml # packages/rs-platform-serialization/Cargo.toml # packages/rs-platform-value-convertible/Cargo.toml # packages/rs-platform-value/Cargo.toml # packages/rs-platform-version/Cargo.toml # packages/rs-platform-versioning/Cargo.toml # packages/rs-sdk/Cargo.toml # packages/simple-signer/Cargo.toml # packages/strategy-tests/Cargo.toml # packages/wallet-lib/package.json # packages/wasm-dpp/Cargo.toml # packages/wasm-dpp/package.json # packages/withdrawals-contract/Cargo.toml # packages/withdrawals-contract/package.json # yarn.lock
QuantumExplorer
approved these changes
Jul 9, 2024
6 tasks
shumkov
added a commit
to dashpay/dash-network-deploy
that referenced
this pull request
Jul 19, 2024
* chore: update to Platform 1.0.0-dev.16 * chore: update dashmate config for dashpay/platform#1883 * fix: invalid dashmate template json * chore: support recent dashmate version * chore: active EHF * style: move variable at the end of the task name * fix: fail if vars are not set properly * chore: use private interface for grovedb visualiser * chore: disable EHF activation * chore: enable EHF activation
ktechmidas
pushed a commit
to dashpay/dash-network-deploy
that referenced
this pull request
Jul 21, 2024
* chore: update to Platform 1.0.0-dev.16 * chore: update dashmate config for dashpay/platform#1883 * fix: invalid dashmate template json * chore: support recent dashmate version * chore: active EHF * style: move variable at the end of the task name * fix: fail if vars are not set properly * chore: use private interface for grovedb visualiser * chore: disable EHF activation * chore: enable EHF activation * feat: configure dashd devnet quorums * fix: incorrect variables * fix: more incorrect variables :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Currently, all platform services are using the same RPC user and work queue to process commands. This approach has many downsides:
quorum sign
(signing arbitrary data with quorum member key)What was done?
How Has This Been Tested?
With tests
Breaking Changes
None
Checklist:
For repository code-owners and collaborators only