Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: rework function tests to have asset unlock functionality activated via mn_rr #5644

Closed
PastaPastaPasta opened this issue Oct 23, 2023 · 2 comments
Closed

test: rework function tests to have asset unlock functionality activated via mn_rr #5644

PastaPastaPasta opened this issue Oct 23, 2023 · 2 comments
Assignees
@knst

Comments

@PastaPastaPasta
Copy link
Member

see todo introduced here: 1d500f8#diff-e771a3dd26d84715d137f42a9d77361684707ebb905310fc678ada1e47d6112fR59

This should reword the functional test to work while the credit pool is increasing in the background due to mn_rr; then remove the conditional check in validation for regtest special case.

This should be updated before RC.2.
@PastaPastaPasta PastaPastaPasta added this to the 20 milestone Oct 23, 2023
@PastaPastaPasta PastaPastaPasta mentioned this issue Oct 23, 2023
Merged
5 tasks
@UdjinM6 UdjinM6 modified the milestones: 20, 20.1 Nov 14, 2023
@UdjinM6
Copy link

UdjinM6 commented Mar 5, 2024

still not fixed https://github.com/dashpay/dash/blob/v20.1.0/src/evo/specialtxman.cpp#L60, moving to v21

@UdjinM6 UdjinM6 modified the milestones: 20.1, 21 Mar 5, 2024
@UdjinM6 UdjinM6 removed this from the 21 milestone Jul 26, 2024
@knst
Copy link
Collaborator

knst commented Nov 14, 2024

done. see #6269

@knst knst closed this as completed Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@knst knst

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@knst @UdjinM6 @PastaPastaPasta