Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(drive)!: orderBy for where clauses with in and startsWith #199

Merged
merged 1 commit into from
Jan 19, 2022
Merged

fix(drive)!: orderBy for where clauses with in and startsWith #199

merged 1 commit into from
Jan 19, 2022

Conversation

jawid-h
Copy link
Collaborator

@jawid-h jawid-h commented Jan 19, 2022 •
edited by shumkov
Loading

Issue being fixed or feature implemented

Allowing using orderBy for properties that have in and startsWith in their where clause. Since they are range queries as well.

What was done?

  • updated validateQuery function

How Has This Been Tested?

Unit tests

Breaking Changes

Some existing queries won't be valid anymore

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@jawid-h jawid-h requested review from shuplenkov and shumkov and removed request for shumkov and antouhou January 19, 2022 08:16
@jawid-h jawid-h changed the title feat(drive): allow using orderBy for properties having in and startsWith in last where clause fix(drive): using orderBy for properties having in and startsWith in last where clause was not allowed Jan 19, 2022
@shumkov shumkov changed the title fix(drive): using orderBy for properties having in and startsWith in last where clause was not allowed fix(drive): orderBy for where clauses with in and startsWith Jan 19, 2022
shumkov
shumkov approved these changes Jan 19, 2022
View reviewed changes
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jawid-h jawid-h merged commit ec8454f into v0.22-dev Jan 19, 2022
@jawid-h jawid-h deleted the feat/in-clause branch January 19, 2022 11:29
@shumkov shumkov changed the title fix(drive): orderBy for where clauses with in and startsWith fix(drive)!: orderBy for where clauses with in and startsWith Jan 20, 2022
@shumkov shumkov added this to the v0.22.0 milestone Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shumkov shumkov shumkov approved these changes

@shuplenkov shuplenkov shuplenkov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.22.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jawid-h @shumkov @shuplenkov