feat: register system contracts on initChain
#182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 6 alerts when merging fac858a into dd6d9ee - view on LGTM.com new alerts:
|
|
This pull request introduces 6 alerts when merging 09a458d into dd6d9ee - view on LGTM.com new alerts:
|
shumkov
reviewed
Jan 10, 2022
shumkov
reviewed
Jan 10, 2022
shumkov
reviewed
Jan 10, 2022
|
This pull request introduces 6 alerts when merging 09ee728 into 0ca47a4 - view on LGTM.com new alerts:
|
shumkov
requested changes
Jan 12, 2022
packages/wallet-lib/src/types/Identities/methods/getIdentityHDKeyById.js
Outdated
Show resolved
Hide resolved
shumkov
reviewed
Jan 13, 2022
shumkov
requested changes
Jan 13, 2022
packages/dashmate/src/listr/tasks/setup/local/initializePlatformTaskFactory.js
Outdated
Show resolved
Hide resolved
thephez
added a commit
to thephez/platform-tutorial-testing
that referenced
this pull request
Jan 25, 2022
no longer necessary due to dashpay/platform#192 and dashpay/platform#182
thephez
added a commit
to thephez/platform-tutorial-testing
that referenced
this pull request
Mar 3, 2022
no longer necessary due to dashpay/platform#192 and dashpay/platform#182
thephez
added a commit
to thephez/platform-tutorial-testing
that referenced
this pull request
Mar 28, 2022
* chore: update to 0.22-dev dependencies * feat: switch to devnet * fix: use renamed contract publish method * feat!: add newly required name to contract index * chore: update DPNS contract ID * chore: update DPNS contract id * chore: update dependency * feat: add client without wallet for read only ops * feat!: don't override DPNS contract id no longer necessary due to dashpay/platform#192 and dashpay/platform#182 * feat: add update contract test (disabled) * test: enable contract update test that doesn't work * fix: temporary fix for contract cache issue To be removed after next release of platform 0.22-dev * fix: correct assert check * chore: remove some commented out sections * ci: update node version to 14 and comment out DPNS contract ID * chore: update ip * chore: update dependencies * chore: update some timeouts * fix: use a non-dust value * feat: add test queries * feat: add query test * refactor: remove a describe layer minor description updates also * feat: use seed node instead of IP for client * feat: add query tests for <, <=, >, >= both asc/desc * feat: added both asc/desc test for startsWith, startAt, and startAfter * feat: set default orderby and add limit param with default * refactor: categorize queries * feat: expand cases for startAt * refactor: change test structure * test: fix check for startsWith queries * chore: update params * test: re-enable some tests and fix * chore: update dependencies to dev.14 * refactor: move queries into own folder * chore: update timeouts and return additional info * chore: bump dependencies to dev.16 * ci: enable remaining tests and update params * feat: update to v0.22 dash dependencies * feat: switch back to testnet and disable test not used in v0.22 * feat: switch query test to testnet and update params
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
To simplify system data contract setup and registration and be able to use them right away. Registration is now moved to
initChainmethod of drive.What was done?
systemIdsfor system data contracts containingcontractIdandownerIdpredefinedDPNS_MASTER_PUBLIC_KEY,DASHPAY_MASTER_PUBLIC_KEY,FEATURE_FLAGS_MASTER_PUBLIC_KEY,MASTERNODE_REWARD_SHARES_MASTER_PUBLIC_KEYenv varibales to Drive to be able to set them as master keys for system data contract identitiesHow Has This Been Tested?
Breaking Changes
Checklist:
For repository code-owners and collaborators only