Skip to content
This repository has been archived by the owner on Jan 4, 2022. It is now read-only.

feat: introduce consensus error codes #341

Merged
merged 2 commits into from
Aug 26, 2021
Merged

feat: introduce consensus error codes #341

merged 2 commits into from
Aug 26, 2021

Conversation

shumkov
Copy link
Member

@shumkov shumkov commented Aug 22, 2021

Issue being fixed or feature implemented

To better recognize and handle DPP consensus errors we need to assign unique error codes.

What was done?

  • Refactored and restructured error classes
  • Assign error codes to consensus errors
  • Remove duplicate checks (i.e. structure validation on state level)

How Has This Been Tested?

With unit tests

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shumkov shumkov added this to the v0.21.0 milestone Aug 22, 2021
@shumkov shumkov requested review from shuplenkov and jawid-h August 22, 2021 16:11
@shumkov shumkov changed the title feat: introduce error codes feat: introduce consensus error codes Aug 22, 2021
@shumkov shumkov requested a review from antouhou August 25, 2021 09:16
Copy link
Member

@shuplenkov shuplenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@shumkov shumkov merged commit 2b0a86a into v0.21-dev Aug 26, 2021
@shumkov shumkov deleted the error-codes branch August 26, 2021 08:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants