This repository has been archived by the owner on Jan 4, 2022. It is now read-only.
refactor!: split validation logic into basic, signature, fee and state #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 1 alert when merging f9e5d2d into d804607 - view on LGTM.com new alerts:
|
shumkov
changed the title
|
This pull request introduces 2 alerts when merging 9cc0e1b into d804607 - view on LGTM.com new alerts:
|
shumkov
requested review from
shuplenkov,
jawid-h and
antouhou
and removed request for
shuplenkov
shuplenkov
reviewed
Aug 9, 2021
| * @return {Promise<ValidationResult>} | ||
| */ | ||
| // eslint-disable-next-line no-unused-vars | ||
| async function validateIdentityTopUpTransitionState(stateTransition) { |
There was a problem hiding this comment.
Why do we need to keep stateTransition here?
There was a problem hiding this comment.
Just to keep the interface since we still passing the argument here.
antouhou
approved these changes
Aug 10, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
In order to implement error codes for consensus errors, ranged by validation types, we need to refactor validation logic and separate basic, signature, fee, and state validation into separate functions.
What was done?
stateTransition#validateaccept validation optionsvalidateIdentityExistencestore fetched Identity in validation resultHow Has This Been Tested?
With tests.
Breaking Changes
stateTransition.validateStructurerenamed tostateTransition.validateBasicand doesn't perfom signature validationstateTransition.validateDatarenamed tostateTransition.validateStateChecklist:
For repository code-owners and collaborators only