Skip to content
This repository has been archived by the owner on Jan 4, 2022. It is now read-only.

feat: initialization will run only once #315

Merged
merged 3 commits into from
Jun 16, 2021
Merged

feat: initialization will run only once #315

merged 3 commits into from
Jun 16, 2021

Conversation

shuplenkov
Copy link
Member

@shuplenkov shuplenkov commented Jun 16, 2021 •
edited
Loading

Issue being fixed or feature implemented

The initialization will run every time we call initialize function

What was done?

Modified initialize method to run only once per instance

How Has This Been Tested?

Breaking Changes

No

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shuplenkov shuplenkov requested a review from shumkov June 16, 2021 10:13
@shuplenkov shuplenkov added this to the v0.20 milestone Jun 16, 2021
@shuplenkov shuplenkov requested a review from antouhou June 16, 2021 10:15
shumkov
shumkov approved these changes Jun 16, 2021
View reviewed changes
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@shuplenkov shuplenkov merged commit 90b236c into v0.20-dev Jun 16, 2021
@shuplenkov shuplenkov deleted the initialization branch June 16, 2021 13:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shumkov shumkov shumkov approved these changes

@antouhou antouhou Awaiting requested review from antouhou

Assignees
No one assigned
Labels
None yet
Milestone
v0.20
Development

Successfully merging this pull request may close these issues.
2 participants
@shuplenkov @shumkov