This repository has been archived by the owner on Jan 4, 2022. It is now read-only.
feat!: chain Asset Lock proof #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antouhou
reviewed
Apr 12, 2021
...ty/stateTransitions/assetLock/proof/instant/validateInstantAssetLockProofStructureFactory.js
Outdated
Show resolved
Hide resolved
antouhou
reviewed
Apr 12, 2021
...ty/stateTransition/assetLock/proof/chain/validateChainAssetLockProofStructureFactory.spec.js
Outdated
Show resolved
Hide resolved
antouhou
reviewed
Apr 12, 2021
...ty/stateTransition/assetLock/proof/chain/validateChainAssetLockProofStructureFactory.spec.js
Outdated
Show resolved
Hide resolved
antouhou
reviewed
Apr 12, 2021
...ty/stateTransition/assetLock/proof/chain/validateChainAssetLockProofStructureFactory.spec.js
Outdated
Show resolved
Hide resolved
antouhou
reviewed
Apr 12, 2021
...ty/stateTransition/assetLock/proof/chain/validateChainAssetLockProofStructureFactory.spec.js
Outdated
Show resolved
Hide resolved
antouhou
reviewed
Apr 12, 2021
...ty/stateTransition/assetLock/proof/chain/validateChainAssetLockProofStructureFactory.spec.js
Outdated
Show resolved
Hide resolved
antouhou
reviewed
Apr 12, 2021
...tateTransition/assetLock/proof/instant/validateInstantAssetLockProofStructureFactory.spec.js
Outdated
Show resolved
Hide resolved
antouhou
reviewed
Apr 12, 2021
...tateTransition/assetLock/proof/instant/validateInstantAssetLockProofStructureFactory.spec.js
Outdated
Show resolved
Hide resolved
antouhou
reviewed
Apr 12, 2021
...tateTransition/assetLock/proof/instant/validateInstantAssetLockProofStructureFactory.spec.js
Outdated
Show resolved
Hide resolved
added 2 commits
April 12, 2021 14:27
antouhou
previously approved these changes
Apr 12, 2021
shumkov
reviewed
Apr 12, 2021
added 2 commits
April 12, 2021 17:30
shumkov
reviewed
Apr 12, 2021
shumkov
reviewed
Apr 12, 2021
shumkov
reviewed
Apr 12, 2021
lib/identity/stateTransitions/assetLock/proof/chain/ChainAssetLockProof.js
Outdated
Show resolved
Hide resolved
shumkov
reviewed
Apr 12, 2021
...entity/stateTransitions/assetLock/proof/chain/validateChainAssetLockProofStructureFactory.js
Outdated
Show resolved
Hide resolved
shumkov
reviewed
Apr 12, 2021
...entity/stateTransitions/assetLock/proof/chain/validateChainAssetLockProofStructureFactory.js
Outdated
Show resolved
Hide resolved
shumkov
reviewed
Apr 12, 2021
...entity/stateTransitions/assetLock/proof/chain/validateChainAssetLockProofStructureFactory.js
Outdated
Show resolved
Hide resolved
shumkov
reviewed
Apr 12, 2021
...ty/stateTransitions/assetLock/proof/instant/validateInstantAssetLockProofStructureFactory.js
Outdated
Show resolved
Hide resolved
shumkov
reviewed
Apr 16, 2021
...dentity/stateTransitions/assetLockProof/chain/validateChainAssetLockProofStructureFactory.js
Outdated
Show resolved
Hide resolved
shumkov
reviewed
Apr 16, 2021
lib/identity/stateTransitions/assetLockProof/validateAssetLockTransactionFactory.js
Outdated
Show resolved
Hide resolved
added 2 commits
April 16, 2021 16:51
shumkov
reviewed
Apr 20, 2021
...dentity/stateTransitions/assetLockProof/chain/validateChainAssetLockProofStructureFactory.js
Outdated
Show resolved
Hide resolved
shumkov
reviewed
Apr 20, 2021
...dentity/stateTransitions/assetLockProof/chain/validateChainAssetLockProofStructureFactory.js
Outdated
Show resolved
Hide resolved
shumkov
reviewed
Apr 20, 2021
...ity/stateTransition/assetLockProof/chain/validateChainAssetLockProofStructureFactory.spec.js
Outdated
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
What was done?
Implemented new ChainLock Proof Type
Refactored AssetLock Proofs
AssetLock class removed
How Has This Been Tested?
Unit tests
Breaking Changes
AssetLock class removed
New ChainAssetLock proof type
InstantAssetLockProof schema changed
Checklist:
For repository code-owners and collaborators only