Skip to content
This repository has been archived by the owner on Dec 16, 2021. It is now read-only.

refactor: remove java artifacts #78

Merged
merged 1 commit into from
Jun 11, 2020

Conversation

thephez
Copy link
Contributor

@thephez thephez commented Jun 10, 2020

Issue being fixed or feature implemented

These files appear to be artifacts that were never removed. The relevant generated java files now appear in clients/java/org/dash/platform/dapi/v0/.

What was done?

Removed extraneous files

How Has This Been Tested?

N/A

Breaking Changes

N/A

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@thephez thephez added this to the v0.14 milestone Jun 10, 2020
@shumkov
Copy link
Member

shumkov commented Jun 10, 2020

@thephez shouldn't it be a refactor? chore even doesn't appear in the changelog, so it's something very internal.

@thephez thephez changed the title chore: remove java artifacts refactor: remove java artifacts Jun 10, 2020
@thephez
Copy link
Contributor Author

thephez commented Jun 10, 2020

@thephez shouldn't it be a refactor? chore even doesn't appear in the changelog, so it's something very internal.

Updated to refactor. Seems pretty insignificant though - if anyone attempted to use these files I assume it would not work since they were last updated a year ago.

Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thank you 👍

@thephez thephez merged commit 967ba12 into dashevo:v0.14-dev Jun 11, 2020
@thephez thephez deleted the chore/remove-java-artifacts branch June 11, 2020 12:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants