This repository has been archived by the owner on Dec 16, 2021. It is now read-only.
feat: use protocol version interceptor in clients #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shumkov
reviewed
May 11, 2020
clients/nodejs/CorePromiseClient.js
Outdated
| * @param {?Object} credentials | ||
| * @param {?Object} options | ||
| */ | ||
| constructor(hostname, credentials = grpc.credentials.createInsecure(), options = {}) { | ||
| constructor(hostname, version, credentials = grpc.credentials.createInsecure(), options = {}) { |
Move protocolVersion from constructor to setter
shumkov
reviewed
May 11, 2020
| * @param {?Object} credentials | ||
| * @param {?Object} options | ||
| */ | ||
| constructor(hostname, credentials = grpc.credentials.createInsecure(), options = {}) { | ||
| constructor(hostname, version, credentials = grpc.credentials.createInsecure(), options = {}) { |
jawid-h
changed the title
jawid-h
suggested changes
May 12, 2020
shumkov
suggested changes
May 12, 2020
package.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "@dashevo/dapi-grpc", | |||
| "version": "0.12.1", | |||
| "version": "0.13.0-dev.1", | |||
There was a problem hiding this comment.
We need to bump the version in a separate PR (chore) due to conventional changelog flow.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING_CHANGE: you have to set up protocol version via
setProtocolVersionmethod when using promise clients