Skip to content
This repository has been archived by the owner on Dec 16, 2021. It is now read-only.

fix: namespacing of the platform service in the build #57

Merged
merged 2 commits into from
Feb 13, 2020
Merged

fix: namespacing of the platform service in the build #57

merged 2 commits into from
Feb 13, 2020

Conversation

jawid-h
Copy link
Contributor

@jawid-h jawid-h commented Feb 13, 2020

This was the bug that stopped core service from working, as platform service compiled module was shadowing $root of the core services in the same node process.

shuplenkov
shuplenkov approved these changes Feb 13, 2020
View reviewed changes
Copy link
Member

@shuplenkov shuplenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@antouhou antouhou merged commit 2b22219 into master Feb 13, 2020
@antouhou antouhou deleted the fix-namespacing branch February 13, 2020 08:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shuplenkov shuplenkov shuplenkov approved these changes

@shumkov shumkov Awaiting requested review from shumkov

@antouhou antouhou Awaiting requested review from antouhou

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jawid-h @shuplenkov @antouhou