-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
What are the prerequisites / requirements for adding new distro? #179
Comments
Hi @yurishkuro
Indeed everything is validated with the backend validation, short of the actual processing of data: it literally brings up that Distro's collector running on a Lambda function and tests the config that way. Browser-only validation is naturally more limited, and based on a JSON schema from nimbushq/otel-validator. |
@yurishkuro about:
I guess you mean the start order. If not, do you have some useful links on the topic? |
Yes, the start order. Although it's not accessible from the config only, so will be difficult to take into account here. |
@yurishkuro if I read the Collector's extension lifecycle order PR right, there is no way to know statically whether the value of a configuration entry for a given extension references by ID another extension. Given this, I don't think we can do much graphical about it in OTelBin, unfortunately. I fully expect dangling extension references to be found with the backend validation. We'll need to parse and contextualise in the editor:
CC @bripkens and @roshan-gh |
@yurishkuro I am going ahead and closing the issue. Feel free to reopen if there is something that has not been addressed yet. |
Jaeger is working on v2 that will be based on OTEL collector infrastructure, so we could point to this tool for config validation. I have a couple questions:
The text was updated successfully, but these errors were encountered: