Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Allow external iri for subclasses (DEV-4553) #3484

Merged
merged 4 commits into from
Jan 30, 2025
Merged

fix: Allow external iri for subclasses (DEV-4553) #3484

merged 4 commits into from
Jan 30, 2025
+6 −16

Conversation

seakayone
Copy link
Contributor

@seakayone seakayone commented Jan 30, 2025 •
edited
Loading

  • fix: Allow non api complex V2 IRI as subclass IRI
  • fix: Allow ResourceClassIri to be external

Pull Request Checklist

Task Description/Number

Issue Number: DEV-

PR Type

  • build/chore: maintenance tasks (no production code change)
  • docs: documentation changes (no production code change)
  • feat: represents new features
  • fix: represents bug fixes
  • perf: performance improvements
  • refactor: represents production code refactoring
  • test: adding or refactoring tests (no production code change)
  • deprecated: Deprecation warning (ideally referencing a migration guide)

Basic requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

@seakayone seakayone changed the title fix/allow external iri for subclasses fix: Allow external iri for subclasses Jan 30, 2025
Nora-Olivia-Ammann
Nora-Olivia-Ammann approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@Nora-Olivia-Ammann Nora-Olivia-Ammann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I trust you

@seakayone seakayone changed the title fix: Allow external iri for subclasses fix: Allow external iri for subclasses (DEV-4553) Jan 30, 2025
@linear Linear
Copy link

linear bot commented Jan 30, 2025

DEV-4553 Creating a class as a subclass of an external Class fails

@seakayone seakayone merged commit 7fd7f46 into main Jan 30, 2025
9 checks passed
@seakayone seakayone deleted the fix/allow-external-iri-for-subclasses branch January 30, 2025 10:37
@daschbot daschbot mentioned this pull request Jan 30, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nora-Olivia-Ammann Nora-Olivia-Ammann Nora-Olivia-Ammann approved these changes

@BalduinLandolt BalduinLandolt Awaiting requested review from BalduinLandolt BalduinLandolt is a code owner

@mpro7 mpro7 Awaiting requested review from mpro7 mpro7 is a code owner

@siers siers Awaiting requested review from siers siers is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seakayone @Nora-Olivia-Ammann