Fixed #169, checking the timestamp unit when redeem deposits

Author: hackfisher

frame/chainrelay/eth/backing/src/lib.rs

@@ -226,7 +226,8 @@ decl_module! {
 
 				<MomentT<T>>::saturated_from(Moment::try_from(month)? as _)
 			};
-			// TODO: Check the time unit in seconds or milliseconds
+			// https://github.com/evolutionlandorg/bank/blob/master/contracts/GringottsBankV2.sol#L178
+			// The start_at here is in seconds, will be converted to milliseconds later in on_deposit_redeem
 			let start_at = {
 				let start_at = result
 					.params[3]
@@ -238,7 +239,8 @@ decl_module! {
 				<MomentT<T>>::saturated_from(Moment::try_from(start_at)? as _)
 			};
 			let redeemed_ring = {
-				// TODO: div 10**18 and mul 10**9
+				// The decimal in Ethereum is 10**18, and the decimal in Darwinia is 10**9,
+				// div 10**18 and mul 10**9
 				let amount = result.params[5]
 					.value
 					.clone()

frame/staking/src/lib.rs

@@ -2383,7 +2383,7 @@ impl<T: Trait> OnDepositRedeem<T::AccountId> for Module<T> {
 		let controller = Self::bonded(&stash).ok_or(<Error<T>>::NotStash)?;
 		let ledger = Self::ledger(&controller).ok_or(<Error<T>>::NotController)?;
 
-		// TODO: Issue #169, checking the timestamp unit difference between Ethereum and Darwinia
+		// The timestamp unit is different between Ethereum and Darwinia, converting from seconds to milliseconds
 		let start_time = start_time * 1000;
 		let promise_month = months.min(36);