From 510c74de8b22fe09174480adca8e5890044d20bd Mon Sep 17 00:00:00 2001 From: Ben Konyi Date: Mon, 8 Jul 2024 12:34:00 -0400 Subject: [PATCH 1/3] Remove unused variable Follow up to https://github.com/dart-lang/webdev/pull/2458 --- dwds/test/instances/common/test_inspector.dart | 1 - 1 file changed, 1 deletion(-) diff --git a/dwds/test/instances/common/test_inspector.dart b/dwds/test/instances/common/test_inspector.dart index f14dd10fa..f6051ed6a 100644 --- a/dwds/test/instances/common/test_inspector.dart +++ b/dwds/test/instances/common/test_inspector.dart @@ -382,7 +382,6 @@ Object? _getValue(InstanceRef instanceRef) { final _dartCoreLibrary = 'dart:core'; final _dartInterceptorsLibrary = 'dart:_interceptors'; final _dartJsHelperLibrary = 'dart:_js_helper'; -final _dartCollectionLibrary = 'dart:collection'; final _dartRuntimeLibrary = 'dart:_runtime'; final matchRecordClassName = 'Record'; From e62fd1b8e790ca5d12c5cbd228dfd81b4c12b30b Mon Sep 17 00:00:00 2001 From: Ben Konyi Date: Mon, 8 Jul 2024 15:22:39 -0400 Subject: [PATCH 2/3] Fix additional test failure --- dwds/test/instances/common/type_inspection_common.dart | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dwds/test/instances/common/type_inspection_common.dart b/dwds/test/instances/common/type_inspection_common.dart index 8beb91be2..4118c4361 100644 --- a/dwds/test/instances/common/type_inspection_common.dart +++ b/dwds/test/instances/common/type_inspection_common.dart @@ -247,11 +247,11 @@ void runTests({ await onBreakPoint('printSimpleLocalRecord', (event) async { final frame = event.topFrame!.index!; final instanceRef = await getInstanceRef(frame, '{}.runtimeType'); - expect(instanceRef, matchTypeInstanceRef('_IdentityHashSet')); + expect(instanceRef, matchTypeInstanceRef('IdentityHashSet')); final instanceId = instanceRef.id!; final instance = await getObject(instanceId); - expect(instance, matchTypeInstance('_IdentityHashSet')); + expect(instance, matchTypeInstance('IdentityHashSet')); final classId = instanceRef.classRef!.id; expect(await getObject(classId), matchTypeClass); From c79863e487b1b84d1a02cbe27c8ed6aaf19447a2 Mon Sep 17 00:00:00 2001 From: Ben Konyi Date: Mon, 8 Jul 2024 16:26:02 -0400 Subject: [PATCH 3/3] Fix type ] --- dwds/test/instances/common/type_inspection_common.dart | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dwds/test/instances/common/type_inspection_common.dart b/dwds/test/instances/common/type_inspection_common.dart index 4118c4361..e1bdccbbf 100644 --- a/dwds/test/instances/common/type_inspection_common.dart +++ b/dwds/test/instances/common/type_inspection_common.dart @@ -247,11 +247,11 @@ void runTests({ await onBreakPoint('printSimpleLocalRecord', (event) async { final frame = event.topFrame!.index!; final instanceRef = await getInstanceRef(frame, '{}.runtimeType'); - expect(instanceRef, matchTypeInstanceRef('IdentityHashSet')); + expect(instanceRef, matchTypeInstanceRef('IdentitySet')); final instanceId = instanceRef.id!; final instance = await getObject(instanceId); - expect(instance, matchTypeInstance('IdentityHashSet')); + expect(instance, matchTypeInstance('IdentitySet')); final classId = instanceRef.classRef!.id; expect(await getObject(classId), matchTypeClass);