Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim down dependencies for package:unified_analytics #253

Open
eliasyishak opened this issue Mar 14, 2024 · 2 comments
Open

Trim down dependencies for package:unified_analytics #253

eliasyishak opened this issue Mar 14, 2024 · 2 comments

Comments

@eliasyishak
Copy link
Contributor

eliasyishak commented Mar 14, 2024

We should limit how many dependencies we use where possible

@eliasyishak
Copy link
Contributor Author

eliasyishak commented Mar 14, 2024

Use a top level function to take in just the homeDirectory (Directory) object and use the .childDirectory and .childFile methods to fetch the path to the files... this removes the dependency on package:path

Context:

@christopherfujino
Copy link
Member

@parlough if we're still using package:file, we're not really getting rid of the dependency on package:path, as file depends on path: https://github.com/google/file.dart/blob/master/packages/file/pubspec.yaml

That's not to say we shouldn't do your change, but I'm thinking maybe we should strategize more big picture how to actually reduce dependencies in this package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants