Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unorderedMatches misses cases depending on the ordering of the input #2370

Closed
natebosch opened this issue Apr 10, 2018 · 0 comments · Fixed by dart-lang/matcher#74
Closed

unorderedMatches misses cases depending on the ordering of the input #2370

natebosch opened this issue Apr 10, 2018 · 0 comments · Fixed by dart-lang/matcher#74
Labels
package:matcher

Comments

@natebosch
Copy link
Member 

// passes
expect([1, 2], unorderedMatches([greaterThan(0), greaterThan(1)]));

// fails
expect([2, 1], unorderedMatches([greaterThan(0), greaterThan(1)]));
@natebosch natebosch mentioned this issue Apr 10, 2018
Closed
natebosch referenced this issue in dart-lang/matcher Apr 11, 2018
@natebosch
Fix unorderedMatches for poorly ordered input
5ffb489 
Fixes #73

Re-implements the unordered matcher using a recursive search assuming
that matchers can matche multiple values in the input rather than a
greedy algorithm which allows a value to "consume" a matcher that is
needed for some other matcher.

User visible differences:
- May match inputs that would have previously been (incorrectly)
  rejected.
- The failure description no longer includes the index of the matcher
  which is unmatched, and all unmatched matchers are printed rather than
  the first.
natebosch referenced this issue in dart-lang/matcher Apr 11, 2018
@natebosch
Fix unorderedMatches for poorly ordered input
c0e4aba 
Fixes #73

Re-implements the unordered matcher using a recursive search assuming
that matchers can matche multiple values in the input rather than a
greedy algorithm which allows a value to "consume" a matcher that is
needed for some other matcher.

User visible differences:
- May match inputs that would have previously been (incorrectly)
  rejected.
- The failure description no longer includes the index of the matcher
  which is unmatched, and all unmatched matchers are printed rather than
  the first.
natebosch referenced this issue in dart-lang/matcher Apr 11, 2018
@natebosch
Fix unorderedMatches for poorly ordered input
1746fef 
Fixes #73

Re-implements the unordered matcher using a recursive search assuming
that matchers can matche multiple values in the input rather than a
greedy algorithm which allows a value to "consume" a matcher that is
needed for some other matcher.

User visible differences:
- May match inputs that would have previously been (incorrectly)
  rejected.
- The failure description no longer includes the index of the matcher
  which is unmatched, and all unmatched matchers are printed rather than
  the first.
natebosch referenced this issue in dart-lang/matcher Apr 11, 2018
@natebosch
Fix unorderedMatches for poorly ordered input
1e8039a 
Fixes #73

Reimplements the unordered matcher using a recursive search assuming
that matchers can match multiple values in the input rather than a
greedy algorithm which allows a matcher to "consume" a value that is
needed for some other matcher.

User visible differences:
- May match inputs that would have previously been (incorrectly)
  rejected.
- The failure description no longer includes the index of the matcher
  which is unmatched, and all unmatched matchers are printed rather than
  the first.
@natebosch natebosch mentioned this issue Apr 11, 2018
Merged
natebosch referenced this issue in dart-lang/matcher Apr 11, 2018
@natebosch
Fix unorderedMatches for poorly ordered input (#74)
03c582f 
Fixes #73

Reimplements the unordered matcher using a recursive search assuming
that matchers can match multiple values in the input rather than a
greedy algorithm which allows a matcher to "consume" a value that is
needed for some other matcher.

User visible differences:
- May match inputs that would have previously been (incorrectly)
  rejected.
- The failure description may include a number of unmatched
  expectations if more than 1 is unmatched.
mosuem referenced this issue Oct 17, 2024
@natebosch
Fix unorderedMatches for poorly ordered input (dart-lang/matcher#74)
b2d1d0f 
Fixes dart-lang/matcher#73

Reimplements the unordered matcher using a recursive search assuming
that matchers can match multiple values in the input rather than a
greedy algorithm which allows a matcher to "consume" a value that is
needed for some other matcher.

User visible differences:
- May match inputs that would have previously been (incorrectly)
  rejected.
- The failure description may include a number of unmatched
  expectations if more than 1 is unmatched.
@mosuem mosuem transferred this issue from dart-lang/matcher Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
package:matcher
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix unorderedMatches for poorly ordered input dart-lang/matcher
2 participants
@natebosch @mosuem