Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extract method does not work with implicit return at the end #59959

Open
stephane-archer opened this issue Jan 22, 2025 · 0 comments
Open

extract method does not work with implicit return at the end #59959

stephane-archer opened this issue Jan 22, 2025 · 0 comments
Labels
analyzer-refactoring analyzer-server area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P3 A lower priority bug or feature request

Comments

@stephane-archer
Copy link

                  onTap: () async {
                    final LutFoldersState lutFoldersState =
                        await ref.read(lutFoldersProvider.future);
                    ref.read(selectedLutFolderProvider.notifier).state = null;
                    final LutPreviewImagesChangeNotifier
                        lutPreviewImagesChangeNotifier =
                        ref.read(lutPreviewImagesProvider);
                    final String? refImagePath =
                        ref.read(refImgagePathProvider);
                    if (refImagePath == null) {
                      return;
                    }
                    final Resolution? resolution =
                        await ref.read(refImageResolutionProvider.future);
                    if (resolution == null) {
                      return;
                    }
                    await lutPreviewImagesChangeNotifier.cleanAndComputeLuts(
                      lutFoldersState.lutFoldersDir,
                      refImagePath,
                      getPreviewResolution(resolution),
                    );
                  },

extract method by selecting all the code in between the braces {}
Selected statements contain a return statement, but not all possible execution flows exit. Semantics may not be preserved.

just add a return at the end and the code works.
the extraction should work without the return at the end

@stephane-archer stephane-archer added the area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. label Jan 22, 2025
@bwilkerson bwilkerson added P3 A lower priority bug or feature request analyzer-server analyzer-refactoring labels Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
analyzer-refactoring analyzer-server area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P3 A lower priority bug or feature request
Projects
None yet
Development

No branches or pull requests

2 participants