Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

co19 tests should be backported to expect TypeErrors instead of AssertionErrors at boolean conversion boundaries. #41086

Closed
Markzipan opened this issue Mar 17, 2020 · 2 comments
Closed

co19 tests should be backported to expect TypeErrors instead of AssertionErrors at boolean conversion boundaries. #41086

Markzipan opened this issue Mar 17, 2020 · 2 comments
Assignees
@Markzipan
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. NNBD Issues related to NNBD Release

Comments

@Markzipan
Copy link
Contributor

See the following issues:

Tests that should be fixed:

co19_2/Language/Expressions/Unary_Expressions/variable_negative_t03
co19_2/Language/Statements/Assert/execution_t03
co19_2/Language/Statements/Assert/execution_t11
co19_2/Language/Statements/If/condition_evaluation_t02
@Markzipan Markzipan added the NNBD Issues related to NNBD Release label Mar 17, 2020
@Markzipan Markzipan self-assigned this Mar 17, 2020
@Markzipan Markzipan mentioned this issue Mar 17, 2020
Closed
@mit-mit
Copy link
Member

mit-mit commented Mar 19, 2020

cc @eernstg

@mit-mit mit-mit added the area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. label Mar 19, 2020
@eernstg
Copy link
Member

eernstg commented Mar 19, 2020

The required updates occurred in dart-lang/co19@88acb3b and dart-lang/co19@1d5f31b, resolving dart-lang/co19#583.

So I believe this should be closed as a duplicate.

@Markzipan, did you have any further actions in mind for this issue? In that case please re-open, and indicate what you had in mind.

@eernstg eernstg closed this as completed Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Markzipan Markzipan

Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. NNBD Issues related to NNBD Release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Markzipan @eernstg @mit-mit