Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement new prefix semantics for extension methods #39279

Closed
1 of 3 tasks
vsmenon opened this issue Nov 7, 2019 · 8 comments
Closed
1 of 3 tasks

Implement new prefix semantics for extension methods #39279

vsmenon opened this issue Nov 7, 2019 · 8 comments
Assignees
Labels
area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. area-front-end Use area-front-end for front end / CFE / kernel format related issues. P0 A serious issue requiring immediate resolution
Milestone

Comments

@vsmenon
Copy link
Member

vsmenon commented Nov 7, 2019

See dart-lang/language#671

  • Tests / nail down spec change.
  • Implement in CFE.
  • Implement in Analyzer.

FYI - @lrhn @leafpetersen @johnniwinther @stereotype441 - tentatively marking D27 for discussion.

@vsmenon vsmenon added this to the D27 Release milestone Nov 7, 2019
@vsmenon vsmenon added area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. area-front-end Use area-front-end for front end / CFE / kernel format related issues. P0 A serious issue requiring immediate resolution labels Nov 7, 2019
@dgrove
Copy link
Contributor

dgrove commented Nov 7, 2019

This is no longer a P0 for D27, correct?

@leafpetersen
Copy link
Member

This is no longer a P0 for D27, correct?

It may be. There's some desire to do the breaking change version of this, in which case I would prefer we land this in D27.

@leafpetersen
Copy link
Member

We're moving forward with this for D27. @johnniwinther has a CL implementing the change in resolution for the CFE. I'll work with @stereotype441 to get this done in the analyzer today. I'll take over the CL from @lrhn with language tests. For deferred libraries, we will temporarily disallow importing libraries with extensions as deferred unless all extensions are hidden, and we will relax this shortly (this just gives us breathing room to be sure we have the right affordances).

@vsmenon
Copy link
Member Author

vsmenon commented Nov 8, 2019

@a-siva - fyi if flutter rolls are starting today.

@leafpetersen
Copy link
Member

@bwilkerson will handle the analyzer part.

@a-siva
Copy link
Contributor

a-siva commented Nov 8, 2019

Has all of this landed already or is it slated to land today?

@johnniwinther
Copy link
Member

CFE support is in the pipeline: https://dart-review.googlesource.com/c/sdk/+/124540

@leafpetersen
Copy link
Member

This is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. area-front-end Use area-front-end for front end / CFE / kernel format related issues. P0 A serious issue requiring immediate resolution
Projects
None yet
Development

No branches or pull requests

5 participants