Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testing adjusted member conflict rules #33238

Open
eernstg opened this issue May 25, 2018 · 2 comments
Open

Testing adjusted member conflict rules #33238

eernstg opened this issue May 25, 2018 · 2 comments
Labels
area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test).

Comments

@eernstg
Copy link
Member

eernstg commented May 25, 2018 •
edited
Loading

This issue is concerned with the task of ensuring that the updated rules for member declaration conflicts detailed in #33235 have associated language tests.

Note that the table in #33235 (comment) may be helpful when updating/extending existing tests or writing new ones, and also that all conflicts must be compile-time errors in Dart 2 (the language specification says static warning, but an update to compile-time error is in the pipeline)
@eernstg eernstg added the area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test). label May 25, 2018
@eernstg eernstg mentioned this issue May 25, 2018
Open
3 tasks
@eernstg
Copy link
Member Author

eernstg commented May 28, 2018 •
edited
Loading

PS: Please postpone the implementation requested in this issue for a few days—one more update to the language specification is currently under review (marked in #33235 as 'Update under review', handled here). We will add yet another comment here when that update has been resolved.

@eernstg
Copy link
Member Author

eernstg commented May 31, 2018

As of 08c893d, the updated and simplified rules in the specification have been landed, so the work here may proceed.

@askeksa-google askeksa-google mentioned this issue Oct 29, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test).
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eernstg