Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement local class hierarchy analysis for DDC #28801

Closed
vsmenon opened this issue Feb 16, 2017 · 8 comments
Closed

Implement local class hierarchy analysis for DDC #28801

vsmenon opened this issue Feb 16, 2017 · 8 comments
Assignees
@jmesserly
Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures web-dev-compiler
Milestone
1.23

Comments

@vsmenon
Copy link
Member

vsmenon commented Feb 16, 2017

Implement module-level class hierarchy analysis for DDC

We can use this to determine which private and non-escaping public fields can be safely devirtualized.
@vsmenon vsmenon added web-dev-compiler P1 A high priority bug; for example, a single project is unusable or has many test failures labels Feb 16, 2017
@vsmenon vsmenon added this to the 1.23 milestone Feb 16, 2017
@vsmenon
Copy link
Member Author

vsmenon commented Feb 17, 2017

Note, this should go ahead and assume #28809 is in effect.

@vsmenon vsmenon mentioned this issue Feb 17, 2017
Closed
@leafpetersen leafpetersen mentioned this issue Feb 28, 2017
Closed
@kasperl
Copy link

kasperl commented Mar 8, 2017

Any progress on this?

@jmesserly
Copy link

Any progress on this?

Nope. I was pulled into strong mode work and haven't gotten to look at this yet. I'll try and start it today.

@dgrove
Copy link
Contributor

dgrove commented Mar 21, 2017

any update here?

@jmesserly
Copy link

update: just landed a chance that got DDC's build green (132ddca), plus a couple of other CL's needed for rolling our inference changes into internal code (f3f814b, 4f9fff9). So now I can focus on this one.

@jmesserly
Copy link

The great irony of this bug is I had it implemented almost 2 years ago ;)
https://codereview.chromium.org/1090313002/
dart-archive/dev_compiler#52 (comment)

probably that CL is wayyyyy too obsolete to be relevant now! Anyway I hope this one won't take very long.

@jmesserly
Copy link

update: I'm getting really close on this one. Nearly finished implementation & shifting to testing it soon.

@jmesserly
Copy link

https://codereview.chromium.org/2781443003/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmesserly jmesserly

Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures web-dev-compiler
Projects
None yet
Milestone
1.23
Development

No branches or pull requests
4 participants
@jmesserly @dgrove @vsmenon @kasperl