-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editor shouldn't run "pub build --all" #21781
Comments
This comment was originally written by @zoechi I'm not sure about this. dart2dart is a quite valid example of a server side transformer. The only reason it's not used much yet is because it is still experimental and has several issues which prevents it's use in production. |
This comment was originally written by @zoechi I think a better solution would be to exclude |
Neither node.js nor dart2dart are supported platforms, and I don't know that that's likely to change in the near-to-mid future. When we deal with issue #20248, then "pub build --all" might make more sense, but that's not likely to happen for at least the next several quarters and until then the current behavior is broken. |
This comment was originally written by @zoechi Interesting. It seems dart2dart is almost working, beside a few issues. Why would you expect this to take several quarters to be fixed? It still seems that $dart2js is the real issue, why would you want to fix something else instead when you already know that you'll have to fix $dart2js anyway and undo the proposed fix eventually. |
Set owner to @keertip. |
As far as I've heard, no one is currently working on it and there are no active plans to make it fully functional.
Designing and implementing a fully-featured "pub build" for the server would take a lot of time and effort that we don't have available right now. |
This comment was originally written by @zoechi I think to remember that devs mention that dart2dart is actually the way they deploy server side code. (for example http://dartbug.com/21616#c8, http://dartbug.com/19978) I didn't mean full-featured "pub build" but at least work in the intended direction instead some temporary workaround that need to be removed later. |
fixed with https://codereview.chromium.org/779223005/ r=42137 Added Fixed label. |
Thanks for the quick turnaround, Keerti! |
Added this to the 1.9 milestone. |
According to issue #21778, the editor runs "pub build --all" when asked to build a project. This is bad; "pub build --all" will run transformers against "bin/", which is expected to contain server-side application code, which "pub build" currently doesn't support by default.
The text was updated successfully, but these errors were encountered: