Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor shouldn't run "pub build --all" #21781

Closed
nex3 opened this issue Dec 3, 2014 · 10 comments
Closed

Editor shouldn't run "pub build --all" #21781

nex3 opened this issue Dec 3, 2014 · 10 comments
Assignees
Milestone

Comments

@nex3
Copy link
Member

nex3 commented Dec 3, 2014

According to issue #21778, the editor runs "pub build --all" when asked to build a project. This is bad; "pub build --all" will run transformers against "bin/", which is expected to contain server-side application code, which "pub build" currently doesn't support by default.

@DartBot
Copy link

DartBot commented Dec 3, 2014

This comment was originally written by @zoechi


I'm not sure about this. dart2dart is a quite valid example of a server side transformer. The only reason it's not used much yet is because it is still experimental and has several issues which prevents it's use in production.

@DartBot
Copy link

DartBot commented Dec 3, 2014

This comment was originally written by @zoechi


I think a better solution would be to exclude bin by default in the $dart2js transformer.
I guess this needs to be overridable in case someone wants to use the output with Node.js on the server side.

@nex3
Copy link
Member Author

nex3 commented Dec 3, 2014

Neither node.js nor dart2dart are supported platforms, and I don't know that that's likely to change in the near-to-mid future.

When we deal with issue #20248, then "pub build --all" might make more sense, but that's not likely to happen for at least the next several quarters and until then the current behavior is broken.

@DartBot
Copy link

DartBot commented Dec 4, 2014

This comment was originally written by @zoechi


Interesting. It seems dart2dart is almost working, beside a few issues. Why would you expect this to take several quarters to be fixed?

It still seems that $dart2js is the real issue, why would you want to fix something else instead when you already know that you'll have to fix $dart2js anyway and undo the proposed fix eventually.

@clayberg
Copy link

clayberg commented Dec 4, 2014

Set owner to @keertip.
Removed Priority-Unassigned label.
Added Priority-Medium label.

@nex3
Copy link
Member Author

nex3 commented Dec 4, 2014

Interesting. It seems dart2dart is almost working, beside a few issues. Why would you expect this to take several quarters to be fixed?

As far as I've heard, no one is currently working on it and there are no active plans to make it fully functional.

It still seems that $dart2js is the real issue, why would you want to fix something else instead when you already know that you'll have to fix $dart2js anyway and undo the proposed fix eventually.

Designing and implementing a fully-featured "pub build" for the server would take a lot of time and effort that we don't have available right now.

@DartBot
Copy link

DartBot commented Dec 4, 2014

This comment was originally written by @zoechi


I think to remember that devs mention that dart2dart is actually the way they deploy server side code. (for example http://dartbug.com/21616#c8, http://dartbug.com/19978)

I didn't mean full-featured "pub build" but at least work in the intended direction instead some temporary workaround that need to be removed later.

@keertip
Copy link
Contributor

keertip commented Dec 5, 2014

fixed with https://codereview.chromium.org/779223005/ r=42137


Added Fixed label.

@nex3
Copy link
Member Author

nex3 commented Dec 5, 2014

Thanks for the quick turnaround, Keerti!

@clayberg
Copy link

Added this to the 1.9 milestone.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants