Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dart2JS evaluation of !e does not match specified semantics #21196

Closed
eernstg opened this issue Oct 1, 2014 · 1 comment
Closed

Dart2JS evaluation of !e does not match specified semantics #21196

eernstg opened this issue Oct 1, 2014 · 1 comment
Assignees

Comments

@eernstg
Copy link
Member

eernstg commented Oct 1, 2014

Dart2JS generated code fails with an AssertionError in the following test:

Language/12_Expressions/27_Unary_Expressions_A02_t03.

The co19 issue #726 indicates that the first check in this file should expect an AssertionError rather than a type error. When omitting this check, the remaining test succeeds as stated. Since '!e' subjects the value of e to boolean conversion, we should get true (since a string and a closure are converted to false), so Expect.isTrue should succeed rather than throwing a TypeError.

@karlklose
Copy link
Contributor

This should be fixed when we update to co19 r793 or later.


Set owner to @eernstg.
Added Fixed label.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants