Match " after embedded expression

[danrubel]

[user feedback]
When typing
print("${blah}

when I then type a closing ", the editor puts in two ""

eg,
print("${blah}""

• I think that it should try to match with the first "

cheers,
Chris.
////////////////////////////////////////////////////////////////////////////////////
Editor Version: 4349
////////////////////////////////////////////////////////////////////////////////////
OS: Windows 7 - amd64 (6.1)
experimental/projectsview = false
experimental/filesview = false
SDK installed = true
Dartium installed = false
////////////////////////////////////////////////////////////////////////////////////

[DartBot]

This comment was originally written by bb...@hotmail.com

---

you don't need to type the closing one...

if you write this: print("

it should be auto-expanded to: print("")

on my pc it actually works (win7/64/dart editor 4349)

[bwilkerson]

I saw both bugs (not inserting the closing quote and doubling the closing quote) on my Mac using build 4539.

[bwilkerson]

Issue #1820 has been merged into this issue.

[danrubel]

Set owner to @stevemessick.

[stevemessick]

Changing to enhancement since the current behavior is working as intended, but it could use improvement.

---

Removed Type-Defect label.
Added Type-Enhancement label.

[clayberg]

Added this to the Later milestone.

[sethladd]

Confirmed.

---

Removed this from the Later milestone.
Added this to the M6 milestone.
Removed Type-Enhancement label.
Added Type-Defect label.

[stevemessick]

Removed this from the M6 milestone.
Added this to the Later milestone.
Removed Priority-Low label.
Added Priority-Medium label.

[sethladd]

I put this into M6 with Dan R's approval.

---

cc @danrubel.
Removed this from the Later milestone.
Added this to the M6 milestone.

[stevemessick]

Removed the owner.
Added PatchesWelcome label.

[sethladd]

As per an above comment, here's a better way to solve it:

type this:

print(

The editor should auto-add this:

print()

Then type this:

print("

The editor should auto-close like this:

print("")

Sublime does this very well, and it's super useful and makes typing much faster.

[stevemessick]

As mentioned in comment #­1, the editor historically did insert pairs of quotes. I recently broke that behavior in argument lists when I made an enhancement to code completion. It will be fixed soon.

I investigated this issue a couple months ago, during an auto-edit bug sweep. I believe the problem reported originally only occurs when you type everything including the closing paren, then backspace over the closing quote. When you re-type the "closing" quote the editor doesn't recognize it as a close-quote and inserts a matched pair.

[sethladd]

I'd be happy to close this issue if we add back the auto-close of ' and " and ( and [

[stevemessick]

I believe the original behavior has been restored. Feel free to re-open this one if it isn't working, modulo the currently open issue of ('') not auto-closing when typed really fast.

---

Set owner to @stevemessick.
Added NotPlanned label.