Skip to content

Commit

Permalink
Make a method public that is overridden in a subclass
Browse files Browse the repository at this point in the history
Having the method be private causes the interactive tool to be broken.

Change-Id: I9390de3b9510c38c69039f2df38a116802acdf89
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127701
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
  • Loading branch information
bwilkerson authored and commit-bot@chromium.org committed Dec 9, 2019
1 parent 55f86c1 commit 9605cca
Showing 1 changed file with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ class InstrumentationRenderer {
'root': migrationInfo.includedRoot,
'units': <Map<String, dynamic>>[],
'dartPageStyle': dartPageStyle,
'thisUnit': migrationInfo._computeName(unitInfo),
'thisUnit': migrationInfo.computeName(unitInfo),
'links': migrationInfo.unitLinks(unitInfo),
'highlightJsPath': migrationInfo.highlightJsPath(unitInfo),
'highlightStylePath': migrationInfo.highlightStylePath(unitInfo),
Expand Down Expand Up @@ -393,7 +393,7 @@ class MigrationInfo {
count == 1 ? '(1 modification)' : '($count modifications)';
bool isNotCurrent = unit != currentUnit;
links.add({
'name': _computeName(unit),
'name': computeName(unit),
'modificationCount': modificationCount,
'isLink': isNotCurrent,
if (isNotCurrent) 'href': _pathTo(target: unit, source: currentUnit)
Expand All @@ -404,7 +404,7 @@ class MigrationInfo {

/// Return the path to [unit] from [includedRoot], to be used as a display
/// name for a library.
String _computeName(UnitInfo unit) =>
String computeName(UnitInfo unit) =>
pathContext.relative(unit.path, from: includedRoot);

/// The path to [target], relative to [from].
Expand Down

0 comments on commit 9605cca

Please sign in to comment.