-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[dart2js] Added variance support for static subtype checking.
Change-Id: I0731884aad68e3dd7f84658d75e946ca5db62bbe Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127063 Reviewed-by: Sigmund Cherem <sigmund@google.com> Commit-Queue: Kallen Tu <kallentu@google.com>
- Loading branch information
Showing
12 changed files
with
212 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
132 changes: 132 additions & 0 deletions
132
tests/compiler/dart2js/codegen/variance_subtype_cast_test.dart
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,132 @@ | ||
// Copyright (c) 2019, the Dart project authors. Please see the AUTHORS file | ||
// for details. All rights reserved. Use of this source code is governed by a | ||
// BSD-style license that can be found in the LICENSE file. | ||
|
||
import 'package:async_helper/async_helper.dart'; | ||
import '../helpers/compiler_helper.dart'; | ||
|
||
const String LEGACY_COV_CAST = r""" | ||
class LegacyCovariant<T> { | ||
void method() {} | ||
} | ||
foo(param) { | ||
LegacyCovariant<num> c = LegacyCovariant<num>(); | ||
(c as LegacyCovariant<int>).method(); | ||
// present: 'LegacyCovariant_int._as' | ||
} | ||
"""; | ||
|
||
const String LEGACY_COV_NO_CAST = r""" | ||
class LegacyCovariant<T> { | ||
void method() {} | ||
} | ||
foo(param) { | ||
LegacyCovariant<num> c = LegacyCovariant<num>(); | ||
(c as LegacyCovariant<Object>).method(); | ||
// absent: 'LegacyCovariant_Object._as' | ||
} | ||
"""; | ||
|
||
const String COV_CAST = r""" | ||
class Covariant<out T> { | ||
void method() {} | ||
} | ||
foo(param) { | ||
Covariant<num> c = Covariant<num>(); | ||
(c as Covariant<int>).method(); | ||
// present: 'Covariant_int._as' | ||
} | ||
"""; | ||
|
||
const String COV_NO_CAST = r""" | ||
class Covariant<out T> { | ||
void method() {} | ||
} | ||
foo(param) { | ||
Covariant<num> c = Covariant<num>(); | ||
(c as Covariant<Object>).method(); | ||
// absent: 'Covariant_Object._as' | ||
} | ||
"""; | ||
|
||
const String CONTRA_CAST = r""" | ||
class Contravariant<in T> { | ||
void method() {} | ||
} | ||
foo(param) { | ||
Contravariant<num> c = Contravariant<num>(); | ||
(c as Contravariant<Object>).method(); | ||
// present: 'Contravariant_Object._as' | ||
} | ||
"""; | ||
|
||
const String CONTRA_NO_CAST = r""" | ||
class Contravariant<in T> { | ||
void method() {} | ||
} | ||
foo(param) { | ||
Contravariant<num> c = Contravariant<num>(); | ||
(c as Contravariant<int>).method(); | ||
// absent: 'Contravariant_int._as' | ||
} | ||
"""; | ||
|
||
const String INV_CAST1 = r""" | ||
class Invariant<inout T> { | ||
void method() {} | ||
} | ||
foo(param) { | ||
Invariant<num> i = Invariant<num>(); | ||
(i as Invariant<Object>).method(); | ||
// present: 'Invariant_Object._as' | ||
} | ||
"""; | ||
|
||
const String INV_CAST2 = r""" | ||
class Invariant<inout T> { | ||
void method() {} | ||
} | ||
foo(param) { | ||
Invariant<num> i = Invariant<num>(); | ||
(i as Invariant<int>).method(); | ||
// present: 'Invariant_int._as' | ||
} | ||
"""; | ||
|
||
const String INV_NO_CAST = r""" | ||
class Invariant<inout T> { | ||
void method() {} | ||
} | ||
foo(param) { | ||
Invariant<num> i = Invariant<num>(); | ||
(i as Invariant<num>).method(); | ||
// absent: 'Invariant_num._as' | ||
} | ||
"""; | ||
|
||
main() { | ||
runTests() async { | ||
Future check(String test) { | ||
return compile(test, | ||
entry: 'foo', | ||
check: checkerForAbsentPresent(test), | ||
newRti: true, | ||
enableVariance: true); | ||
} | ||
|
||
await check(LEGACY_COV_CAST); | ||
await check(LEGACY_COV_NO_CAST); | ||
await check(COV_CAST); | ||
await check(COV_NO_CAST); | ||
await check(CONTRA_CAST); | ||
await check(CONTRA_NO_CAST); | ||
await check(INV_CAST1); | ||
await check(INV_CAST2); | ||
await check(INV_NO_CAST); | ||
} | ||
|
||
asyncTest(() async { | ||
print('--test from kernel------------------------------------------------'); | ||
await runTests(); | ||
}); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters